Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename have_optional_dependency to import_optional_dependency #3864

Closed
arjxn-py opened this issue Mar 5, 2024 · 0 comments · Fixed by #3866
Closed

Rename have_optional_dependency to import_optional_dependency #3864

arjxn-py opened this issue Mar 5, 2024 · 0 comments · Fixed by #3866
Assignees
@kratman
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows

Comments

@arjxn-py
Copy link
Member

arjxn-py commented Mar 5, 2024

We use have_optional_dependency() to import optional dependencies across codebase which is a wrapper over importlib.import_module() to throw a helpful error message.
@arjxn-py arjxn-py added difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows labels Mar 5, 2024
@kratman kratman mentioned this issue Mar 5, 2024
Merged
6 tasks
@kratman kratman self-assigned this Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kratman kratman

Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: medium To be resolved if time allows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename have_optional_dependency kratman/PyBaMM
2 participants
@kratman @arjxn-py