-
-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nbqa-ruff
with ruff
#3476
Comments
Hello @Saransh-cpp According to this repo which is already use in pre-commit-config.yaml file. But then also we need add new repo in pre-commit-config.yaml file then it is able to do changes in jupyter notebook i have tryed it locally and we only need to remove repo which nbqa_ruff uses so that no conflict happen. |
We don't need to add the formatter for this issue. We just have to extend the linter to jupyter notebooks. The link attached by you explains how to do that - We can then check if it is raising any weird errors and ignore them. |
Hey , I have implemented this one
|
Yes, it isn't supposed to push changes to the repository. The changes should be pushed to a new branch of your fork manually by you. It would be better to keep both of these issues separate as this is more about lining and the other one is more about formatting. I'll be able to help better once you open a PR for this issue! |
I have stop E402 to change by itself but i am still not unable stop the |
astral-sh/ruff#7300 and astral-sh/ruff#8254 should be related, we might want to hold off on this issue until some patches make it upstream |
We can just make useless-semicolon (E703) unfixable like @Rjchauhan18 did for E402 |
Oh yes, that is much better. |
Hello @agriyakhetarpal and @Saransh-cpp |
If this #3478 is the case then we don't need ruff.toml so, better to wait and then change according to pyproject.toml
|
ruff
can now lint jupyter notebooks!Would mostly require changes in
pyproject.toml
and.pre-commit-config.yaml
The text was updated successfully, but these errors were encountered: