-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename "positive electrode diffusivity" to "positive particle diffusivity"? #3229
Labels
difficulty: easy
A good issue for someone new. Can be done in a few hours
priority: medium
To be resolved if time allows
Comments
Non-breaking change with deprecation warning sounds good to me. |
Agreed. |
valentinsulzer
added
difficulty: easy
A good issue for someone new. Can be done in a few hours
priority: medium
To be resolved if time allows
labels
Aug 7, 2023
"Positive electrode particle diffusivity" feels more correct albeit more verbose. What's a 'positive particle'..? |
I think "positive particle" is fairly self-explanatory, we already have a bunch of variables like "Positive particle concentration" |
5 tasks
4 tasks
github-project-automation
bot
moved this from In Progress
to Done
in November 2023 sprint
Jan 27, 2024
github-project-automation
bot
moved this from In Progress
to Done
in December 2023 - January 2024 sprint
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
difficulty: easy
A good issue for someone new. Can be done in a few hours
priority: medium
To be resolved if time allows
It's a better name, but a breaking change so maybe not worth it.
We can make it not breaking by returning "positive particle diffusivity" from
parameter_values["Positive electrode diffusivity"]
with a deprecation warningThe text was updated successfully, but these errors were encountered: