Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: benchmarks are failing #3124

Closed
agriyakhetarpal opened this issue Jul 8, 2023 · 2 comments · Fixed by #3145
Closed

[Bug]: benchmarks are failing #3124

agriyakhetarpal opened this issue Jul 8, 2023 · 2 comments · Fixed by #3145
Labels
bug Something isn't working

Comments

@agriyakhetarpal
Copy link
Member

PyBaMM Version

23.5

Python Version

all

Describe the bug

The scheduled benchmarks and the benchmarks on PRs are failing because the asv configuration fails to find pybtex, since it is not a core dependency but has been shifted to the [cite] extras group after #3044 was merged

Steps to Reproduce

Via the benchmarks_on_push.yml and periodic_benchmarks.yml workflow files

Relevant log output

No response
@agriyakhetarpal agriyakhetarpal added the bug Something isn't working label Jul 8, 2023
@agriyakhetarpal
Copy link
Member Author

I tried adding pybtex to the Python dependencies in 59fa13d, but that did not work—is there a way to install the extras from a built wheel file?

@Saransh-cpp
Copy link
Member

You'll probably need to add pybtex in https://github.com/pybamm-team/PyBaMM/blob/develop/asv.conf.json

@arjxn-py arjxn-py mentioned this issue Jul 12, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Failing Benchmarks arjxn-py/PyBaMM
2 participants
@Saransh-cpp @agriyakhetarpal