Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print names for equivalent circuit models #3036

Open
rtimms opened this issue Jun 14, 2023 · 2 comments
Open

Print names for equivalent circuit models #3036

rtimms opened this issue Jun 14, 2023 · 2 comments
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@rtimms
Copy link
Contributor

rtimms commented Jun 14, 2023

Most of the variables haven't been assigned print names for the equivalent circuit models, so the latex output just prints long names instead of symbols, see

import pybamm

model = pybamm.equivalent_circuit.Thevenin()
model.latexify()
@rtimms rtimms added difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve labels Jun 14, 2023
@kumaryash7
Copy link

@rtimms Hello, myself Yash from India. I am new to the open source. Can you assign me this issue? I have already set up the project.

@medha-14
Copy link
Contributor

I assigned print_names to the variables directly in the update method, and it worked. However, I believe there might be an existing method or mechanism that ensures consistent naming of variables, especially for generating LaTeX representations, which I may have overlooked.Can someone please clarify this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Development

No branches or pull requests

6 participants