Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enertech cell data not included in the release #1266

Closed
valentinsulzer opened this issue Dec 3, 2020 · 1 comment · Fixed by #1267
Closed

Enertech cell data not included in the release #1266

valentinsulzer opened this issue Dec 3, 2020 · 1 comment · Fixed by #1267

Comments

@valentinsulzer
Copy link
Member

Do we need to edit MANIFEST.in? Are there other things we forgot to add to this @tlestang ?
Screen Shot 2020-12-02 at 9 22 44 PM

@tlestang
Copy link
Contributor

tlestang commented Dec 3, 2020

At the moment only files ending in ".py", ".csv" or ".md" are added to the distribution, because we don't want to add any ".pyc" file.

# setup.py (around l. 136)
pybamm_data = []
for file_ext in ["*.csv", "*.py", "*.md", ".txt"]:
    # Get all the files ending in file_ext in pybamm/input dir.
    # list_of_files = [
    #    'pybamm/input/drive_cycles/car_current.csv',
    #    'pybamm/input/drive_cycles/US06.csv',
    # ...
    list_of_files = glob.glob("pybamm/input/**/" + file_ext, recursive=True)
    ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants