-
-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track cycles in solution #1195
Comments
A related functionality that would be nice is the ability to stop a simulation after capacity drops below e.g. 80%. Once the notion of cycle is defined, the discharge capacity for that cycle could be computed. This is not the sort of thing that would be handled by an |
Good idea, yes that would be the place to implement it, and it is separate from I think Jack Lonnborn (@lonnbornj ?) has made a start on this issue, but don't know how far he has got |
I have implemented the first part of this (definition of cycles by the user on creation of an Experiment), and currently working on extracting the cycles again at around that line in |
Change experiment and solution classes so that
solution.cycles
is a list of the cycles (e.g. 1 CCCV charge + CC discharge)See #1176
The text was updated successfully, but these errors were encountered: