From 7d69e7c283e15fb3203d9408212c2490f5fe60b9 Mon Sep 17 00:00:00 2001 From: Robert Timms Date: Fri, 27 Mar 2020 15:47:22 +0000 Subject: [PATCH] #729 changelog --- CHANGELOG.md | 5 +++-- .../graphite_Ecker2015/graphite_diffusivity_Ecker2015.py | 1 - .../test_parameter_sets/test_NCO_Ecker2015.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4895abe060..b6b8f53d71 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,12 +2,13 @@ ## Features +- Added LiNiCoO2 parameter set from Ecker et. al. ([#922](https://github.com/pybamm-team/PyBaMM/pull/922)) - Added `DummySolver` for empty models ([#915](https://github.com/pybamm-team/PyBaMM/pull/915)) - Added functionality to broadcast to edges ([#891](https://github.com/pybamm-team/PyBaMM/pull/891)) - Reformatted and cleaned up `QuickPlot` ([#886](https://github.com/pybamm-team/PyBaMM/pull/886)) - Added thermal effects to lead-acid models ([#885](https://github.com/pybamm-team/PyBaMM/pull/885)) -- Add new symbols `VariableDot`, representing the derivative of a variable wrt time, - and `StateVectorDot`, representing the derivative of a state vector wrt time +- Add new symbols `VariableDot`, representing the derivative of a variable wrt time, + and `StateVectorDot`, representing the derivative of a state vector wrt time ([#858](https://github.com/pybamm-team/PyBaMM/issues/858)) - Added additional notebooks showing how to create and compare models ([#877](https://github.com/pybamm-team/PyBaMM/pull/877)) - Added `Minimum`, `Maximum` and `Sign` operators diff --git a/pybamm/input/parameters/lithium-ion/anodes/graphite_Ecker2015/graphite_diffusivity_Ecker2015.py b/pybamm/input/parameters/lithium-ion/anodes/graphite_Ecker2015/graphite_diffusivity_Ecker2015.py index 0efe92849a..7d8ffab42f 100644 --- a/pybamm/input/parameters/lithium-ion/anodes/graphite_Ecker2015/graphite_diffusivity_Ecker2015.py +++ b/pybamm/input/parameters/lithium-ion/anodes/graphite_Ecker2015/graphite_diffusivity_Ecker2015.py @@ -36,7 +36,6 @@ def graphite_diffusivity_Ecker2015(sto, T, T_inf, E_D_s, R_g): Solid diffusivity """ - # D_ref = FunctionParameter("Measured negative electrode diffusivity [m2.s-1]", sto) D_ref = 8.4e-13 * exp(-11.3 * sto) + 8.2e-15 arrhenius = exp(-E_D_s / (R_g * T)) * exp(E_D_s / (R_g * 296)) diff --git a/tests/unit/test_parameters/test_parameter_sets/test_NCO_Ecker2015.py b/tests/unit/test_parameters/test_parameter_sets/test_NCO_Ecker2015.py index a295b7d5ff..5d83923187 100644 --- a/tests/unit/test_parameters/test_parameter_sets/test_NCO_Ecker2015.py +++ b/tests/unit/test_parameters/test_parameter_sets/test_NCO_Ecker2015.py @@ -1,5 +1,5 @@ # -# Tests for LG M50 parameter set loads +# Tests for Ecker parameter set # import pybamm import unittest