-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog post automata #433
Blog post automata #433
Conversation
This seems to work when tested locally, so I'm not sure why the build here is failing. Either way, I'll go ahead and take this out of draft. |
Looks like its just failing bc the image URL doesnt exist yet (bc the PR hasnt been merged). Seems like we should have a specific category for blog posts like this that are about reviewed packages, right? Might be nice to add something like a packages:
- automata
- another_pkg To list the packages that a given blog post mentions, so that in the future we might be able to do stuff like automatically add backlinks to review issues, and more generally index when we write about different packages (even if we dont have the stuff in place for that right now) |
@sneakers-the-rat that sounds like a good idea. Should I make an issue for this? It seems easy enough to do, but we'd have to go through the posts and pick out all of the ones about new packages, and that's a little out of scope for just this PR imo. |
Thank you so much for submitting a blog post! I'll go through and do a review today, and we can always go back and update the category based on Leah's decision. @sneakers-the-rat is spot-on with the build failing due to the URL not existing yet. We've implemented a fix for this, but found that it's not consistently working (yet!) Adding a new category is up to @lwasser, so I'll defer to her on that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic post, @eliotwrobson! Thank you so much for taking the time to write such a detailed and thoughtful post about automata
. I don't have any suggested changes, and didn't catch any errors or typos, so am happy to approve the post.
I'll leave the final review and merge to @lwasser, but please don't hesitate to reach out to me here or on Slack with any questions!
(Also @kierisi reminds me that i forgot to say that I love the post, sorry to get distracted with metadata thingz and ignore the actual thing you did) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eliotwrobson this looks great to me! i'm making two suggestions in one inline comment here.
- let's go ahead and add pyos-accepted as a category!
- if we add the wide class to the post it is a bit more comfortable of a reading width .
If you are ok with these changes, let's merge! we can play with the tags and categories idea later when we explore further what a package landing page might look like!
If you are ok with these changes, we can definitely merge so if anyone sees this before me please go ahead and merge.
Alternatively, if you want to hold off on the category addition width of the page for me we can just merge as is. Thank you so much for submitting this blog post on automata
!
Co-authored-by: Leah Wasser <[email protected]>
@lwasser thank you for the suggestion! I went ahead and committed the inline changes. I think it makes sense to tag as long as the tag name likely won't change, means fewer things to wrestle with in the later PR. |
wonderful!! i'll go ahead and merge this!! @eliotwrobson it's been really wonderful working with you both on the automata review and here!! i'm really glad that you've joined our community!! |
@all-contributors please add @eliotwrobson for code, review |
@eliotwrobson already contributed before to code, review |
@lwasser thank you and likewise! Happy to be a part of the community here 😀 |
Adding blog post for review pyOpenSci/software-submission#152
Still need to test locally.