-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CATE uplift validation methods #836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks for the update. I've made a few minor suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks great. I'm approving the changes, but note the DCO failure on the "Checks" tab - you'll need to amend your commits to sign them off.
Signed-off-by: amarv <[email protected]>
Signed-off-by: amarv <[email protected]>
Signed-off-by: amarv <[email protected]>
Signed-off-by: amarv <[email protected]>
Signed-off-by: amarv <[email protected]>
Signed-off-by: amarv <[email protected]>
Signed-off-by: amarv <[email protected]>
Signed-off-by: amarv <[email protected]>
Signed-off-by: amarv <[email protected]>
88981b6
to
078630a
Compare
I’ve amended the commits accordingly, so the branch should be ready to merge now. Thanks! |
Added additional functionality to the DRTester validation class to include AUTOC validation metric, with associated inference methods. Also included ability to plot uplift curve methods (both QINI and TOC curves) and cleaned up handling of multiple treatments.
Added additional functionality to the DRTester validation class to include AUTOC validation metric, with associated inference methods. Also included ability to plot uplift curve methods (both QINI and TOC curves) and cleaned up handling of multiple treatments.
Modified files are:
Test cases were extended to include the modifications, maintaining 100% coverage:
Looking forward to any comments.