Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the alpha grid search in the DebiasedLasso. #211

Merged
merged 2 commits into from
Jan 8, 2020

Conversation

moprescu
Copy link
Contributor

@moprescu moprescu commented Jan 7, 2020

  • Changed the alpha grid for the alpha=auto setting to the default
    LassoCV alpha path
  • Cleaned up tests for sklearn extensions of linear models

* Changed the alpha grid for the alpha=`auto` setting to the default
LassoCV alpha path
* Cleaned up tests for sklearn extensions of linear models
@moprescu moprescu added the enhancement New feature or request label Jan 7, 2020
@moprescu moprescu self-assigned this Jan 7, 2020
@moprescu moprescu removed the request for review from heimengqi January 7, 2020 19:00
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a test that fails with the old selection strategy but passes now? Otherwise LGTM.

@moprescu
Copy link
Contributor Author

moprescu commented Jan 7, 2020

Would it be possible to add a test that fails with the old selection strategy but passes now? Otherwise LGTM.

@kbattocchi
This is not actually a bug, it's just that the alpha grid I was choosing was too coarse and sometimes for scenarios where smaller alpha was more optimal, there could be some bias in the debiasedLasso compared with the LassoCV for example.

I am now using the LassoCV path search for the alphas which takes a bit longer, but gives more optimal results in these corner cases. But it's hard to test because we don't know the true best alpha and small bias can be hard to measure.

@moprescu moprescu requested a review from kbattocchi January 7, 2020 22:35
@kbattocchi
Copy link
Collaborator

@moprescu I thought Vasilis had a concrete example where the CIs were way off because of the chosen alpha, and hoped maybe that could be adapted into a useful test to make sure we don't regress.

@kbattocchi
Copy link
Collaborator

Nevermind, discussed offline; I was misunderstanding.

@moprescu moprescu merged commit 8370694 into master Jan 8, 2020
@moprescu moprescu deleted the moprescu/update_alpha_grid branch January 8, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants