Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use setuptools? #465

Closed
phaer opened this issue Oct 18, 2018 · 3 comments
Closed

Use setuptools? #465

phaer opened this issue Oct 18, 2018 · 3 comments
Labels

Comments

@phaer
Copy link

phaer commented Oct 18, 2018

Hi,

Maybe I am missing something, but it looks line only a single line needs to be changed
to use setuptools:

-from distutils.core import setup
+from setuptools import setup

which would enable users to generate a wheel with

python3 setup.py bdist_wheel

They issue I've had was that I tried to mirror packages in internal, branch-specific pypi repositories for a CI system and twine complained that the .tar.gz from pypi.python.org did not include meta data in the package.

What do you think? Are there any drawbacks or difficulties? I'd be glad to help :)

@phaer phaer mentioned this issue Feb 8, 2019
@SecT0uch
Copy link

SecT0uch commented Feb 8, 2019

Maybe you should try to make a PR

@phaer
Copy link
Author

phaer commented Feb 9, 2019

Or maybe you should? Sorry, I mostly opened the issue to help others who depend on PyPDF2 and are trying to build a wheel, but I don't really feel like adding another PR which won't ever be merged to what seems to be a dead project with over 60 open PRs.

@SecT0uch
Copy link

SecT0uch commented Feb 9, 2019

You seem to know what you're talking about while I don't know setuptools so much.
Anyway it seems indeed to be a dead project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants