New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filenames that contain `.` are missing the extension #95

Open

pxlrbt opened this issue Jul 14, 2023 · 0 comments

Labels

bug

Owner

pxlrbt commented Jul 14, 2023

This code breaks exports with filenames that contain a dot.

protected function ensureFilenameHasExtension(string $filename): string
{
    return Str::contains($filename, '.')
        ? $filename
        : $filename.'.'.$this->getDefaultExtension();
}

pxlrbt added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment