Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] make 'Octo comment add' work for visual #303

Closed
alex-popov-tech opened this issue Jun 18, 2022 · 2 comments
Closed

[feature] make 'Octo comment add' work for visual #303

alex-popov-tech opened this issue Jun 18, 2022 · 2 comments

Comments

@alex-popov-tech
Copy link

Issue Description

Type: feature request

Describe what feature you want

Please make 'Octo comment add' work on visual, it will be more consise and understandable than now using OctoAddReviewComment. Also relevant for suggestions.

Anything else we need to know?

Related to #301

@pwntester
Copy link
Owner

Turns out there was a bug introduced when I changed the mappings to use "vim.keymap.set". I took the opportunity to improve the support for multiline comments and thread buffer responsivness. Please check out latest version and let me know if it works for you now (no need to use OctoAddReview commands, in fact I removed them)

@alex-popov-tech
Copy link
Author

its working now like a charm, thank you <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants