Add configuration key to readthedocs.yml #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you help me see the "bug" that is fixed? A page that builds correctly now that didn't before? Edit: nvm I see the associated issue. |
echedey-ls
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
LGTM! 🚀
I've left a small note regarding whatsnew's wording down below.
For context, this is the Sphinx blog post that describes the breaking change in detail: https://about.readthedocs.com/blog/2024/12/deprecate-config-files-without-sphinx-or-mkdocs-config/
|
I think this is ready to merge (after #2352) |
|
@RDaxini can you please resolve the conflict and then we can merge? |
Done |
wholmgren
reviewed
Jan 21, 2025
wholmgren
reviewed
Jan 21, 2025
wholmgren
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests addedUpdates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Not super familiar with build tools but wanted to give this a go... seemed straightforward.