Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting issue with IV curve gallery example? #1894

Closed
williamhobbs opened this issue Oct 20, 2023 · 2 comments · Fixed by #1895
Closed

Plotting issue with IV curve gallery example? #1894

williamhobbs opened this issue Oct 20, 2023 · 2 comments · Fixed by #1895
Milestone

Comments

@williamhobbs
Copy link
Contributor

Describe the bug
When I run the IV curve example (https://pvlib-python.readthedocs.io/en/stable/gallery/iv-modeling/plot_singlediode.html), the annotation arrows show up in a second figure:

image

If I move plt.show() from the current line down below the draw_arrow functions, it looks correct:
image

Is this a bug? Or maybe there's something different with my setup?

@kandersolar
Copy link
Member

I see no reason to call plt.show() before finishing the figure assembly. Its current placement in the code was probably an oversight. A PR to fix it would be welcome!

@williamhobbs
Copy link
Contributor Author

PR submitted!

@kandersolar kandersolar added this to the v0.10.3 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants