Warning about passing lock by value in xsync.Range function. Is that expected?

[mernesteze-eng]

Currently getting this warning on the range function, is that expected

'func' passes a lock by the value: type 'globals.RequestArtifacts' contains 'sync.WaitGroup' contains 'interface{}' which is 'sync.Locker' 

Here's some preceding context

test := xsync.NewMapOf[string, globals.RequestArtifacts]()
	test.Range(func(key string, value globals.RequestArtifacts) bool {

When I change test schema structure to

test := xsync.NewMapOf[string, *globals.RequestArtifacts]()
	test.Range(func(key string, value *globals.RequestArtifacts) bool {

warning clears. Do our xsync generic types need to be pointers to structs instead of the struct itself? Do we lose or not gain any performance boost by using pointers?

[puzpuzpuz]

Do our xsync generic types need to be pointers to structs instead of the struct itself? Do we lose or not gain any performance boost by using pointers?

Internally, key and value is stored in the following struct:

type entryOf[K comparable, V any] struct {
	key   K
	value V
}

So, if the struct is "simple" (no mutexes), you should use the struct and it will be copied. This is preferred for performance reasons. If not, pointers must be used.