Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Subscribing to already subscribed channel #43

Closed
gaurav112 opened this issue Mar 7, 2018 · 4 comments
Closed

Subscribing to already subscribed channel #43

gaurav112 opened this issue Mar 7, 2018 · 4 comments

Comments

@gaurav112
Copy link

gaurav112 commented Mar 7, 2018

I am using this js client in a cordova application. I am suscribing to all the rooms when connected(onSuccess). But wen the application looses connection and reconnects, the connection success is called again and messages are recieved the nuber of times the connection was made. I don't know if this is a bug or we as a developer have to handle this issue.

@hamchapman
Copy link
Contributor

hamchapman commented Mar 7, 2018

That does sound like a bug, and likely because subscriptions aren't being cleaned up appropriately. I think this might be fixed in an upcoming release, the PR for which is here: #31

That PR comes with a host of other changes though, in particular, moving to using Promises where possible in place of callbacks.

I'll find out if this is indeed fixed in the upcoming release and let you know.

@hamchapman
Copy link
Contributor

This should indeed be fixed in the upcoming release, the PR for which I linked to before. I'll close this issue for now as it will soon be resolved 👍

Thanks!

@kristiankyvik
Copy link

I am experiencing the same problem here, has this been fixed already?

@hamchapman
Copy link
Contributor

It should have been fixed when the linked PR (#31) was merged.

If you're experiencing a similar issue please could you create a new issue describing the problem and how to recreate it? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants