Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy without exposing app keys #3

Open
gilfuser opened this issue Jul 19, 2018 · 2 comments
Open

Deploy without exposing app keys #3

gilfuser opened this issue Jul 19, 2018 · 2 comments

Comments

@gilfuser
Copy link

Hi.
I'm making an app based on yours.
I would like to ask you how could I deploy it, let's say also in Heroku, without exposing the Pusher app keys.

best regards,
Gil

@leesio
Copy link
Contributor

leesio commented Jul 19, 2018

Hi 👋
I’d recommend including your key and secret I’m environment variables when deploying to heroku. You can find out more about how to do that in the heroku docs on config vars

That’s how we solve similar problems at pusher!

@gilfuser
Copy link
Author

gilfuser commented Jul 25, 2018

Hi @leesio
Thank you for your response.
I managed to use config vars in server.js but not in datachannel-demo.js because I can not require there. Is there a way to do it?

EDIT: Answering to myself: no, there isn't and is not necessary to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants