Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput placeholder vanishes when using size “tiny" #269

Open
tomzaoral opened this issue Jun 10, 2022 · 2 comments
Open

TextInput placeholder vanishes when using size “tiny" #269

tomzaoral opened this issue Jun 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@tomzaoral
Copy link
Member

Is it bug or feature? 🤓

Screenshot 2022-06-10 at 9 40 30

@tomzaoral tomzaoral added the bug Something isn't working label Jun 10, 2022
@samuelg0rd0n
Copy link
Contributor

Sorry, I have to say I totally missed this. Since I'm not used to using Issues here on GitHub... 😊

Well, I'd say it's half a feature and half a bug 😃 Placeholder that you normally see for different sizes is not a real placeholder (HTML attribute) because we need to animate this so it's a <label> tag that is positioned absolutely and that we animate. For the smallest size (before tiny, now xs), we hide the label because the input is already so small it wouldn't fit or at least it wouldn't look nice. But of course, in this case, we can fallback to using standard placeholder that will disappear once you start typing.

I'll fix this and create a PR. Thanks for noticing.

@samuelg0rd0n samuelg0rd0n self-assigned this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants