Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #24

Merged
merged 4 commits into from
Jul 28, 2021
Merged

Update dependencies #24

merged 4 commits into from
Jul 28, 2021

Conversation

flounders
Copy link
Contributor

@flounders flounders commented Jul 28, 2021 •
edited by thomashoneyman
Loading

Description of the change

Build was failing due to certain dependencies not being explicitly listed. Added the required dependencies to spago.dhall.

Checklist:

  • Added the change to the changelog's "Unreleased" section with a link to this PR and your username
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation in the README and/or documentation directory
  • Added a test for the contribution (if applicable)

Steven Michael Williams added 2 commits July 27, 2021 23:07
Update dependencies
164a63f 
Build was failing due to certain dependencies not being explicitly listed.
Update CHANGELOG.md
9bb8896
thomashoneyman
thomashoneyman reviewed Jul 28, 2021
View reviewed changes
CHANGELOG.md Outdated
@@ -9,6 +9,7 @@ Breaking changes:
New features:

Bugfixes:
- Updated dependencies to clear build errors related to unlisted dependencies (#24)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving this to the “Other improvements” section, as it’s a purely internal change? You can also add your username if you would like — ie (#24 by @flounders)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, I just updated it.

Steven Michael Williams and others added 2 commits July 28, 2021 09:28
@thomashoneyman thomashoneyman merged commit 9f61bc8 into purescript-contrib:main Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flounders @thomashoneyman