Pure prompt contains newline in VSCode terminal

[MrAru]

I'm not sure if this issue should be reported to pure or VSCode. As the title suggests, when using the Pure theme for fish shell in VSCode, it seems that there is a newline character after the prompt, separating the user input from the prompt content. This issue does not occur when using the original fish shell without any theme. Even if I set pure_enable_single_line_prompt to true it still occurs. Please refer to the screenshot below. Any suggestion could be helpful, thanks in advance.

pure theme

pure theme, set pure_enable_single_line_prompt true

original fish theme

Env

Pure

4.8.3

Fish

fish, version 3.3.1

OS/distribution

LSB Version: :core-4.1-amd64:core-4.1-noarch
Distributor ID: Rocky
Description: Rocky Linux release 8.7 (Green Obsidian)
Release: 8.7
Codename: GreenObsidian

[edouard-lopez]

Got something similar behavior as you when I'm not using tmux , but not when using other terminals

Terminal	Behavior	Screenshot	Comment
VSC (without Tmux)	❌		input on different line ❯
VSCode with Tmux	✅		input on ❯ line
GNOME Terminal Version 3.49.92 for GNOME 45	✅		input on ❯ line
Hyper 3.4.1	✅		input on ❯ line
kitty 0.26.5	✅		input on ❯ line

Conclusion

I would say it's a difference in VSCode as multiple terminal applications render correctly.

[edouard-lopez]

There is an issue on vcsode repo microsoft/vscode#187185 and a solution on IlanCosman/tide#433. The issue comes from "terminal.integrated.shellIntegration.enabled being enabled.

1. Disable this feature,
2. Kill the VSCode terminal (trash/bin icon on the top right of the panel)
3. Open terminal again

[MrAru]

@edouard-lopez Thanks for your help and this really fixed my issue! It seems that VSC does some magic with its shell integration procedure. I'm happy to close this issue now and enjoy this awesome theme 😄