Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interaction of cl-lib and cl function checks #192

Open
lassik opened this issue Oct 8, 2020 · 1 comment
Open

Interaction of cl-lib and cl function checks #192

lassik opened this issue Oct 8, 2020 · 1 comment

Comments

@lassik
Copy link
Contributor

lassik commented Oct 8, 2020

Given a file foo.el:

;;; foo.el --- Foo
;; Package-Version: 0.1.0
;; Homepage: https://example.com/
;; Package-Requires: ((emacs "24.3") (cl-lib "0.5"))
;;; Commentary:
;; foo
(defun foo (x) (cl-parse-integer x))
(provide 'foo)
;;; foo.el ends here

M-x package-lint-current-buffer says:

warning: An explicit dependency on cl-lib <= 1.0 is not needed on Emacs >= 24.3.

But changing the Package-Requires line to:

;; Package-Requires: ((emacs "24.3"))

gives:

error: You should depend on (emacs "25.1") or the cl-lib package if you need `cl-parse-integer'.

If it's possible to use this cl function with the old Emacs 24.3 by specifying a version of the cl-lib package, should package-lint take that into account?

@purcell
Copy link
Owner

purcell commented Oct 8, 2020

I don't think there's any version of cl-lib on ELPA that can be automatically installed in Emacs 24.3 by specifying it as a dependency, since Emacs 24.3 already believes it has version 1.0 of that library installed. Presumably that function was only added to the bundled cl-lib in Emacs 25.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants