Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the dependencies from Cask/pkg file #110

Open
Fuco1 opened this issue Aug 13, 2018 · 1 comment
Open

Read the dependencies from Cask/pkg file #110

Fuco1 opened this issue Aug 13, 2018 · 1 comment

Comments

@Fuco1
Copy link

Fuco1 commented Aug 13, 2018

I'm not sure if this is already a feature but probably not because I can not get it working.

I have this pkg file for smartparens

(define-package "smartparens" "1.11.0" "Automatic insertion, wrapping and paredit-like navigation with user defined pairs."
  '((emacs "24.3")
    (dash "2.13.0")
    (cl-lib "0.3")))

it has the emacs dependency but package-lint still complains that

1:111: warning: You should depend on (emacs "24") if you need lexical-binding.
53:12: error: You should depend on (emacs "24.4") if you need `subr-x'.
137:9: error: You should depend on (emacs "24.3") if you need `read-only-mode'.
....
9051:13: error: You should depend on (emacs "24.3") if you need `user-error'.
9398:19: error: You should depend on (emacs "24.4") if you need `add-face-text-property'.

How should I fix this? Do we need to teach package-lint to look for pkg files?

@purcell
Copy link
Owner

purcell commented Aug 14, 2018

Yep, we could, but then there's also an open question about multi-file packages. It's good that flycheck now supports reporting errors found in other files - that could be relevant here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants