Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API hostname regex should support a dash in hostname #282

Open
mattkirby opened this issue Jul 13, 2018 · 2 comments
Open

API hostname regex should support a dash in hostname #282

mattkirby opened this issue Jul 13, 2018 · 2 comments

Comments

@mattkirby
Copy link
Contributor

From #218

Found a small bug making the API choke on hostnames containing a dash:

lib/vmpooler/api/helpers.rb:120 reads:

if domain && hostname =~ /^\w+.#{domain}$/
but should be:

if domain && hostname =~ /^[a-zA-Z0-9-]+.#{domain}$/

@yachub
Copy link

yachub commented Apr 20, 2023

We're migrating issue management to Jira, so tracking this has been moved to https://puppet.atlassian.net/browse/POOLER-218

@yachub yachub closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2023
@yachub
Copy link

yachub commented Aug 3, 2023

We're migrating issue management to Jira, so tracking this has been moved to https://puppet.atlassian.net/browse/POOLER-218

Apologies for the noise, we went full circle here and decided to move from Jira Cloud to GitHub Projects instead.

@yachub yachub reopened this Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants