(MAINT) Ensure vendored path check works with mix of module builds #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the dsc_base_provider checked for the legacy vendored DSC module path before the new, specific path; in cases where the modules installed are a mix of old and new path, the old path will _always_ exist, even if the specific module is not there (because it is looking for the *container*, as the container can hold any number of vendored modules). This commit inverts the search order, seeking the most specific location *first* and falling back to the general location if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the dsc_base_provider checked for the legacy vendored DSC module path before the new, specific path; in cases where the modules installed are a mix of old and new path, the old path will always exist, even if the specific module is not there (because it is looking for the container, as the container can hold any number of vendored modules).
This commit inverts the search order, seeking the most specific location first and falling back to the general location if needed.