(Maint) Fix ensurability in the dsc base provider #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(MAINT) Prep for 0.6.0 release
This was referenced Nov 25, 2020
Prior to this commit the dsc base provider erroneously only tried to compare ensurable states on resources which are NOT ensurable instead of only comparing them on resources which ARE ensurable. This commit corrects that error and adds special handling in invoke_get_method for trimming empty properties when returning the representation of an absent resource on the system in order to prevent flapping during Puppet runs.
pmcmaw
approved these changes
Nov 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the dsc base provider erroneously only tried to compare ensurable states on resources which are NOT ensurable instead of only comparing them on resources which ARE ensurable.
This commit corrects that error and adds special handling in
invoke_get_methodfor trimming empty properties when returning the representation of an absent resource on the system in order to prevent flapping during Puppet runs.This should be rebased and merged after #68 and a
0.6.1release immediately prepped and cut.