(CAT-1991) - Skip missing dirs invalid_dir method #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordanbreen28
force-pushed
the
cat-1991-skip_missing_dir_check
branch
2 times, most recently
from
cbf9c07 to
bad8a2e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #334 +/- ##
==========================================
- Coverage 92.10% 92.08% -0.03%
==========================================
Files 6 6
Lines 722 720 -2
==========================================
- Hits 665 663 -2
Misses 57 57 ☔ View full report in Codecov by Sentry. |
Prior to this commit, the invalid_directories? method in pwsh::util would return true if a directory did not exist. We found this to cause issues with updating packages which modifiy the LIB env, as missing entries during install/uninstall/upgrade would raise an error and exit. Now, we alter the check to skip entries that do not exist, and only flag for an invalid directory if the path supplied is not a directory.
This commit updates the initialize method in Pwsh::Manager to only warn not raise on invalid_directory returning true.
jordanbreen28
force-pushed
the
cat-1991-skip_missing_dir_check
branch
from
bad8a2e to
729b60d
Compare
david22swan
approved these changes
Aug 20, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates
invalid_directories?method in Pwsh::Util to ignore non existent entries for thelibenv.Also warn rather than raise when invalid directory is found, this is not a critical error and is overprotective (see internal jira).
Refactored
invalid_directories?method, new code removes unnecessary lines and opts for the direct return value of filtered array using a conditional.any?that meets the new requirements of the method.More unit testing added to cover the new functioanlity.
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist