(FEAT) Ensure hash key casing methods work on arrays #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennsarti
reviewed
Dec 3, 2019
|
Added a maint commit to clarify the parameter names for the hash methods. |
DavidS
reviewed
Dec 3, 2019
DavidS
reviewed
Dec 3, 2019
lib/pwsh/util.rb
Outdated
| if hash.is_a?(Hash) | ||
| hash.inject({}) do |memo, (k, v)| # rubocop:disable Style/EachWithObject | ||
| def symbolize_hash_keys(object) | ||
| if object.is_a?(Hash) |
There was a problem hiding this comment.
It's a bit weird that this function has a different code pattern than the pascal_case and snake_case variants. Makes it hard to see whether they're all three doing the same or not.
There was a problem hiding this comment.
and if they're actually all the same shape, then you could replace them with a apply_key_mutator(f, o) function so that
def pascal_case_hash_keys(object)
apply_key_mutator(&:pascal_case, o)
end
etc.
There was a problem hiding this comment.
Replaced with a private method.
Prior to this commit the hash key casing methods, snake_case_hash_keys and pascal_case_hash_keys, only properly handled hashes, not hashes inside arrays or other objects. Now, if passed an array, the methods will iterate over each item in the array, recursively casing any keys discovered in hashes. Additionally, they will not error if passed any objects which are not hashes or arrays; instead, they will return that object as-is.
This commit standardizes the hash util methods on taking object as a parameter as they handle more data types than just hashes. It also conforms the hash util methods to use the same underlying structure by utilizing a new private method, apply_key_mutator, to do the heavy lifting. The other hash utility methods now create a proc for the conforming of the keys and pass that to the mutator.
This commit updates the casing methods to handle symbols if passed them - they will return a string if given a string and a symbol if given a symbol, properly cased. This does away with the weird requirement to cast the keys to strings, case them, and resymbolize them in the hash mutation procs.
RandomNoun7
approved these changes
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit the hash key casing methods,
snake_case_hash_keysandpascal_case_hash_keys, only properly handled hashes, not hashes inside arrays or other objects.Now, if passed an array, the methods will iterate over each item in the array, recursively casing any keys discovered in hashes. Additionally, they will not error if passed any objects which are not hashes or arrays; instead, they will return that object as-is.