(GH-125) Fix dsc provider canonicalization for absent resources #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit the canonicalize method in the DSC Base provider did some unneccessary work: - it _always_ called invoke_get_method if a resource was not already in the canonicalized cache - it erroneously canonicalized a resource which *should* exist to values which were returned as nil from invoke_get_method because DSC returns the ensure value as absent and nil for other properties This commit adds logic shortcuts to obviate unneccessary canonicalization of the resource when the should value for dsc_ensure is absent (because a resource being deleted does not care about casing) as well as when the should value for dsc_ensure is present but the resource itself does not actually exist on the system (canonicalizing to a nil state is a bug).
|
While this is currently functional, there is some refactoring necessary to make the tests more maintainable and readable; I ran out of time today but will get that in tomorrow. |
DavidS
reviewed
May 13, 2021
spec/unit/puppet/provider/dsc_base_provider/dsc_base_provider_spec.rb
Outdated
Show resolved
Hide resolved
DavidS
approved these changes
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR the
canonicalizemethod in the DSC Base Provider did some unneccessary work:invoke_get_methodif a resource was not already in the canonicalized cachenilfrominvoke_get_methodbecause DSC returns the ensure value asabsentandnilfor other propertiesThis commit adds logic shortcuts to obviate unneccessary canonicalization of the resource when the should value for
dsc_ensureisabsent(because a resource being deleted does not care about casing) as well as when the should value fordsc_ensureispresentbut the resource itself does not actually exist on the system (a resource which is being created should treat it's own definition as canonical).