(MODULES-11051) Ensure environment variables are not incorrectly munged in the PowerShell Host #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit standardizes the code style and syntax used in the init file for the PowerShell host. It does not change any of the code functionality, merely its appearance for readability.
This commit refactors the Reset-ProcessEnvironmentVariables function and calling in the PowerShell host init script to cache the environment variables when the host is started up by just enumerating them and then using that cached array to reset them inside the host. This ensures that the value of the environment variable matches those outside of the PowerShell Host instead of using expected inheritance; this resolves the issue where a process scope environment variable does not match the expected User > Machine inheritance order, as with the TEMP variable under the System user. This also simplifies the overall code. All existing unit tests continue to pass with this change.
DavidS
approved these changes
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
Reset-ProcessEnvironmentVariablesfunction and calling in the PowerShell hostinit.ps1script to cache the environment variables when the host is started up by just enumerating them and then using that cached array to reset them inside the host.This ensures that the value of the environment variable matches those outside of the PowerShell Host instead of using expected inheritance; this resolves the issue where a Process scope environment variable does not match the expected User > Machine inheritance order, as with the
TEMPvariable under the System user.This also simplifies the overall code. All existing unit tests continue to pass with this change.
This PR also includes a minor maintenance commit for syntax and style standardization in the init script.