(Maint) Ensure canonicalize correctly compares sorted hashes #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements different sorting of Hash and Array values.
|
|
|
Hey @Hvid I would like to thank you for taking the time to create this PR. In our testing currently there are test failures, and at this particular time they are rubocop failures, it would be great if you could work on getting these resolved so we are 1 step closer to getting this PR merged. |
|
Hi @pmcmaw Thanks, ruby is not really my home turf, but i gave it a go :) |
|
No worries @Hvid, for it not being your home turf you've done a pretty decent job. Im going to add Michael for a review as he is the specialist in this particular area. But honestly, nice work for picking it up and just going with it :-) Thank you! |
michaeltlombardi
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Awesome, thanks so much for the contribution @Hvid! 🎉 LGTM!
michaeltlombardi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements different sorting of Hash and Array values.