(GH-105) Ensure set runs on ambiguous ensure states #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomNoun7
approved these changes
Feb 11, 2021
Prior to this commit if a resource is ensurable but the value of ensure on the target node was not Present or Absent the call to run Invoke-DscResource never gets made. This commit updates the logic in the set method to call update() if the state of the ensurable resource is ambiguous from a CRUD perspective, which is preferable to not running set at all.
michaeltlombardi
deleted the
gh-105/main/call-update-on-ambiguous-ensure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit if a resource is ensurable but the value of
ensureon the target node was notPresentorAbsentthe call to runInvoke-DscResourcenever gets made.This commit updates the logic in the
setmethod to callupdate()if the state of the ensurable resource is ambiguous from a CRUD perspective, which is preferable to not running set at all.