Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apt::Key upper cases the key #217

Closed
janschumann opened this issue Feb 4, 2014 · 3 comments
Closed

Apt::Key upper cases the key #217

janschumann opened this issue Feb 4, 2014 · 3 comments

Comments

@janschumann
Copy link

For installing mariadb on ubuntu I tried the following resource:

apt::source { 'mariadb':
  location   => 'http://mirror2.hs-esslingen.de/mariadb/repo/5.5/ubuntu',
  release    => 'precise',
  repos      => 'main',
  key        => '0xcbcb082a1bb943db',
  key_server => 'hkp://keyserver.ubuntu.com:80',
}

This fails because the key will be upper cased in key.pp

 $upkey = upcase($key)

I fixed it by using the parameter $key instead. Should I contribute this change? @see janschumann/puppetlabs-apt@9ab5da3

Or can I work around it otherwise?

@janschumann
Copy link
Author

Of course I would add/fix tests if this change would be accepted.

@daenney
Copy link

daenney commented Feb 4, 2014

If you remove the 0x it'll work but I agree, it should work with or without it. I'll make sure ensure that #212 includes the necessary code and tests to make sure ensure 0x qualified keys work.

@janschumann
Copy link
Author

@daenney thanks. So I´ll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants