feat: use captureBeyondViewport in Page.captureScreenshot

[sadym-chromium]

BREAKING CHANGE:

• page.screenshot makes a screenshot with the clip dimensions, not cutting it by the ViewPort size.

[mathiasbynens]

page.screenshot makes a screenshot with the clip dimensions, not cutting it by the ViewPort size.

Are you saying this restores the pre-v6.0.0 behavior?

[mathiasbynens]

Why is this test being removed?

[sadym-chromium]

The bug https://crbug.com/1173457 was closed with the motivation: if you need a screenshot bigger than the ViewPort, you have to use the flag captureBeyondViewport .

This change uses the flag, screenshot works in the new way, but in the way can easily be called "correctly", the same way Firefox does it. No further TODO needed.

It used to be 2 similar tests with the different expectations:

• skipped should clip elements to the viewport size without artefacts
• should clip elements to the viewport size with artefacts

I removed one of them and adjusted the expectations. It covers the issue point and the breaking change, verifying the screenshot works correctly.

[mathiasbynens]

Ack, thanks!

[sadym-chromium]

@mathiasbynens

Are you saying this restores the pre-v6.0.0 behavior?

• Before 90, the screenshot is cut based on the ViewPort position and size.
• In 90 without captureBeyondViewport, the screenshot is cut based on the ViewPort size and clip position with some unwilling artefacts out of the ViewPort.
• In 90 with captureBeyondViewport the screenshot is cut based on the clip position and size.

From this point, using captureBeyondViewport is still a breaking change, but it makes the screenshots work properly.

[google-cla]

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

[mahnunchik]

Why captureBeyondViewport option doesn't documented? https://github.com/puppeteer/puppeteer/blob/v8.0.0/docs/api.md#pagescreenshotoptions

[mahnunchik]

@sadym-chromium could you please make captureBeyondViewport configurable. To be able to not use this patch #7043 (comment)

[sadym-chromium]

PR #7063 should address the issue.

[jschfflr]

LGTM!