Allow semicolon in url-path #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests on MacOSX are flaky, here are the same tests on the same commit, passing: https://travis-ci.org/zarelit/puma/builds/577223164 |
|
😮 Thanks for pushing this up so quickly! Will review soon. |
evanphx
approved these changes
Aug 28, 2019
|
Thank you for the review and merge @evanphx @nateberkopec |
costis
added a commit
to reevoo/puma
that referenced
this pull request
Nov 4, 2019
* Allow unquoted semicolon in URL path * Add test about semicolon * Regenerate grammar to allow semicolon in request_path We need to run revieworld-admin/apiv4 with puma on kubernetes. Puma did not allow character ';' in urls, until version 4.2. In commit beab7f0 in puma/puma they have added support for ';'. We tried running revieworld-admin/apiv4 with puma 4.2 but we had intermittent 500s. This is a backport of beab7f0 to v3.12.1. We can use this for now, only for rw admin & apiv4, until we find a proper solution. puma@05de1ac
This was referenced Mar 9, 2021
Merged
This was referenced Mar 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow unescaped semicolons in the URL, improves compatibility with applications that use it as a parameter separator such as Angular 2 or Redmine.
Fixes #1122