Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pr-assign input #26

Open
ocobles opened this issue Jul 17, 2024 · 2 comments
Open

Add a pr-assign input #26

ocobles opened this issue Jul 17, 2024 · 2 comments
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features

Comments

@ocobles
Copy link

ocobles commented Jul 17, 2024

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

pr-assign defaults to "@me" in upgrade-provider. This makes the action fail when we use the GITHUB_TOKEN secret instead of a bot/user token because it cannot assign PRs to github-actions[bot]

Affected area/feature

@ocobles ocobles added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Jul 17, 2024
@ocobles
Copy link
Author

ocobles commented Jul 17, 2024

I just learned that it can be specified in the configuration file but that is still a limitation for us to be able to configure it dynamically with github.actor

@iwahbe iwahbe removed the needs-triage Needs attention from the triage team label Jul 18, 2024
@iwahbe
Copy link
Member

iwahbe commented Jul 18, 2024

Hi @ocobles. Thanks for the suggestion. This should be straightforward to add that. This should be a one line change if you are open to contributing. I believe that the only change necessary is to add a new conditioned flag to this line:

upgrade-provider "$REPO" --kind="$KIND" ${TBV:+--target-bridge-version="$TBV"} ${REV:+--pr-reviewers="$REV"} ${DESC:+--pr-description="$DESC"} ${PREF:+--pr-title-prefix="$PREF"} ${PUV:+--target-pulumi-version="$PUV"} ${JV:+--java-version="$JV"}

Edit: reread the origin comment.

@iwahbe iwahbe added awaiting-feedback Blocked on input from the author good-first-issue Start here if you'd like to start contributing to Pulumi and removed awaiting-feedback Blocked on input from the author labels Jul 18, 2024
@iwahbe iwahbe changed the title Add a pr-assing input Add a pr-assign input Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants