Incoherence between documented behaviour and runtime with Stack.StackStatus.LastUpdate.State field

[rodcloutier]

Problem description

According to the documentation/comment, in StackStatus.LastUpdate.State field we should see either succeeded or failed. We instead see the current commit (ie master).

pulumi-kubernetes-operator/pkg/apis/pulumi/v1alpha1/stack_types.go

Line 100 in 79f0048

State string `json:"state,omitempty"`

This seems to be a misconception and used throughout the code:

Compare with commit

pulumi-kubernetes-operator/pkg/controller/stack/stack_controller.go

Line 217 in 79f0048

if !isStackMarkedToBeDeleted && (instance.Status.LastUpdate != nil && instance.Status.LastUpdate.State == instance.Spec.Commit) {

Assigned a failed message

pulumi-kubernetes-operator/pkg/controller/stack/stack_controller.go

Lines 267 to 270 in 79f0048

	instance.Status.LastUpdate = &pulumiv1alpha1.StackUpdateState{
	State: pulumiv1alpha1.FailedStackStateMessage,
	Permalink: permalink,
	}

Assigned a commit

pulumi-kubernetes-operator/pkg/controller/stack/stack_controller.go

Lines 297 to 305 in 79f0048

	if instance.Status.LastUpdate == nil {
	instance.Status.LastUpdate = &pulumiv1alpha1.StackUpdateState{
	State: instance.Spec.Commit,
	Permalink: permalink,
	}
	} else {
	instance.Status.LastUpdate.State = instance.Spec.Commit
	instance.Status.LastUpdate.Permalink = permalink
	}

[lukehoban]

@vivek I believe this was fixed with #107?

[viveklak]

Fixed by #107. Closing.