Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiToken is not marked secret in the schema #1013

Closed
t0yv0 opened this issue Dec 19, 2024 · 1 comment · Fixed by #1014
Closed

apiToken is not marked secret in the schema #1013

t0yv0 opened this issue Dec 19, 2024 · 1 comment · Fixed by #1014
Assignees
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@t0yv0
Copy link
Member

t0yv0 commented Dec 19, 2024

Describe what happened

There are several configuration variables that are potentially sensitive, apiToken I think is one of them. apiKey maybe, apiUserServiceKey.

Not having these marked secret in the schema risks leaking secrets.

Sample program

N/A

Log output

N/A

Affected Resource(s)

N/A

Output of pulumi about

N/A

Additional context

N/A

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Dec 19, 2024
@guineveresaenger guineveresaenger self-assigned this Dec 20, 2024
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Dec 20, 2024
@guineveresaenger guineveresaenger removed the needs-triage Needs attention from the triage team label Jan 2, 2025
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #1014 and shipped in release v5.46.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants