Read all AWS env vars #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleverguy25
reviewed
Feb 12, 2020
stack72
force-pushed
the
lukehboban/252
branch
from
e576b6b to
2df7aa1
Compare
|
@lukehoban just pushed a quick fix to the branch for the range statement |
stack72
added
the
impact/no-changelog-required
stack72
approved these changes
Feb 12, 2020
For both programmatic access, and for pre configuration, we must read in all the appropriate env vars. Fixes #252
stack72
force-pushed
the
lukehboban/252
branch
from
2df7aa1 to
cc5cd84
Compare
lukehoban
force-pushed
the
lukehboban/252
branch
from
cc5cd84 to
1c3d76e
Compare
pgavlin
approved these changes
Feb 12, 2020
lukehoban
pushed a commit
that referenced
this pull request
Mar 11, 2020
In #874 we added config defaults from environment variables for four new configuration settings. Thees config defaults are used in two places: (1) `aws.config` and (2) the defaults for `aws.Provider`. For (1) these changes were a good thing, but for (2) they led to values from the environment getting baked into checkpoints that should not be. It's not clear to me that we should be doing (2) at all - that is - I don't think `region` or `profile` should be picked up from the environment and baked into the checkpoint file either. But for now we'll just revert the more recent change here which has led to the more significant immediate issue. Part of #814.
lukehoban
pushed a commit
that referenced
this pull request
Mar 11, 2020
In #874 we added config defaults from environment variables for four new configuration settings. Thees config defaults are used in two places: (1) `aws.config` and (2) the defaults for `aws.Provider`. For (1) these changes were a good thing, but for (2) they led to values from the environment getting baked into checkpoints that should not be. It's not clear to me that we should be doing (2) at all - that is - I don't think `region` or `profile` should be picked up from the environment and baked into the checkpoint file either. But for now we'll just revert the more recent change here which has led to the more significant immediate issue. Part of #814. Fixes #890.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For both programmatic access, and for pre-configuration, we must read in all the appropriate env vars. We were previously failing to read many of the env vars for setting up programmatic access, and failing to read any of the env vars for pre-configuration checks.
Fixes #252