Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a recommended way to work with Security groups #3806

Open
t0yv0 opened this issue Apr 11, 2024 · 4 comments
Open

Provide a recommended way to work with Security groups #3806

t0yv0 opened this issue Apr 11, 2024 · 4 comments
Labels
impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features

Comments

@t0yv0
Copy link
Member

t0yv0 commented Apr 11, 2024

aws.ec2.SecurityGroup could use some cleanup to provide unambiguous user guidance on which usage is recommended and which is deprecated.

Some specifics:

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 12, 2024

History: 1eaf9df

Looks like some research is needed to inform direction here as taking a different guess as to which way of using the resources is canonical from what upstream is doing will put us in a position where we're not receiving functionality from upstream but having to maintain bw-compat on what upstream is deprecating or discouraging.

@t0yv0 t0yv0 added the kind/enhancement Improvements or new features label Apr 22, 2024
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 22, 2024

Related: #3788

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 22, 2024

Related: #1387 (import, refresh)

@t0yv0
Copy link
Member Author

t0yv0 commented Apr 24, 2024

Some follow up from #2246 : the solution here is needs to fix managed_policy_arn import that happens from a Role and breaks the intended invariant. Any fixes are likely breaking.

Also note for consideration suggested by @pierskarsenbarg - recommending to use more resources has cost implications in per-resource pricing.

@t0yv0 t0yv0 added the impact/breaking Fixing this issue will require a breaking change label Apr 24, 2024
@corymhall corymhall self-assigned this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/breaking Fixing this issue will require a breaking change kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants