Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cdnHost to cookie consent manager and add dev key for growthbook #13072

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

sicarul
Copy link
Contributor

@sicarul sicarul commented Oct 8, 2024

This PR sets the cdn host for Segment's open source cookie consent to our custom domain to avoid the cookie consent from breaking our website

As a note, we're using an archived open source library and Segment recommends other approaches: https://segment.com/docs/privacy/consent-management/consent-faq/

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@cnunciato cnunciato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- so the issue was just that cdnHost wasn't set?

@sicarul sicarul merged commit 51d74d2 into master Oct 8, 2024
8 checks passed
@sicarul sicarul deleted the pablo/set-cdn-host-cookie-consent-manager branch October 8, 2024 15:20
@sicarul
Copy link
Contributor Author

sicarul commented Oct 8, 2024

LGTM -- so the issue was just that cdnHost wasn't set?

Exactly! We had to set it to our custom domain since we switched out from segment's cdn

sicarul added a commit to pulumi/registry that referenced this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants