Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer tools need --no-sandbox option on exec to be enabled in the AppImage version #397

Open
2 tasks done
machitgarha opened this issue Feb 23, 2023 · 7 comments
Open
2 tasks done
Labels
bug Something isn't working

Comments

@machitgarha
Copy link
Contributor

Thanks in advance for your bug report!

  • Have you reproduced this issue in incognito/private browsing?
  • Have you made sure you issue doesn't already exist?

Where is the URL that this occurs?

https://pulsar-edit.dev/docs/atom-archive/hacking-atom/#check-for-errors-in-the-developer-tools

What's your issue?

In order for someone to be able to enable developer tools, he needs to run Pulsar with --no-sandbox, as stated here.

As people should go there to play with the issue they encountered, they might not be able to enable developer tools, so this is unintuitive.

Which OS/Browser/Version does this happen on?

Not relevant

Steps to Reproduce/Additional Details:

No response

@machitgarha machitgarha added the bug Something isn't working label Feb 23, 2023
@Spiker985
Copy link
Member

--no-sandbox is included as a part of the pulsar.sh file on mac and linux

@machitgarha
Copy link
Contributor Author

I see, but if I don't add the --no-sandbox option manually, the shortcut to open Developer Tools doesn't work (i.e. Ctrl+Shift+I).

P.S: I'm using the AppImage version of the Pulsar, although it shouldn't make a difference.

@machitgarha
Copy link
Contributor Author

So, the problem is AppImage-specific. The AppRun file of the AppImage is not the same as pulsar.sh, and it doesn't call it too (i.e. located in resources/pulsar.sh).

@machitgarha machitgarha changed the title Developer tools need --no-sandbox option on exec to be enabled Developer tools need --no-sandbox option on exec to be enabled in the AppImage version Feb 23, 2023
@Daeraxa
Copy link
Member

Daeraxa commented Feb 23, 2023

We do note this on the appimage download page:

[1] Appimage may require --no-sandbox as an argument to run correctly on some systems.

If you have a solution for it then we are all for it.

@confused-Techie
Copy link
Member

So while we appreciate the bug report, like mentioned this is explicitly mentioned on our website for this one type of download. And as we don't have any known way to fix this (other than bumping Node thus Chromium, which this version of chromium is the actual reason for this issue) I'm inclined to say to close the issue as there's no other known way to fix this for AppImage.

It will be fixed, but it's otherwise a documented issue. But please if there is some other methodology to fix this we would all be happy to have it. Or otherwise if we feel it's a good idea to leave this open as a sort of documentation of the issue we could also do that as well. But otherwise I would hope to keep our issue count down.

Again thanks a ton for contributing!

@machitgarha
Copy link
Contributor Author

machitgarha commented Feb 24, 2023

Ah. @Daeraxa and @confused-Techie, I didn't pay enough attention. Sorry.

Because I have some experience with AppImages, maybe I can fix this. I'll look into it if I find time.

Thanks for your quick responses!

@confused-Techie
Copy link
Member

Ah. @Daeraxa and @confused-Techie, I didn't pay enough attention. Sorry.

Because I have some experience with AppImages, maybe I can fix this. I'll look into it if I find time.

Thanks for your quick responses!

No sorry needed. But if you are able to that'd be amazing! Wishing you good luck with it, feel free to ask any questions here or on our Discord (May get a faster response there)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants