Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "command installer" specs #303

Closed
5 tasks done
mauricioszabo opened this issue Jan 5, 2023 · 1 comment
Closed
5 tasks done

Fix "command installer" specs #303

mauricioszabo opened this issue Jan 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@mauricioszabo
Copy link
Contributor

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Does your issue already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

Pulsar have a "command installer" that installs both ppm and pulsar in the PATH.

The problem is that the test (that resides here: https://github.com/pulsar-edit/pulsar/blob/master/spec/command-installer-spec.js) is insanely flaky. For example, it starts with:

     apmBinPath = path.join(
       resourcesPath,
       'app',
       'apm',
       'node_modules',
       '.bin',
       'apm'
     );

This is not the path anymore that we use. So I commented them for now, and we need a way to actually test the real command instead

Which OS does this happen on?

🍎 macOS

OS details

Any

Which CPU architecture are you running this on?

None

What steps are needed to reproduce this?

Run tests on CI

Additional Information:

No response

@mauricioszabo mauricioszabo added the bug Something isn't working label Jan 5, 2023
@mauricioszabo mauricioszabo changed the title Fix "command installer" problems Fix "command installer" specs Jan 5, 2023
@confused-Techie confused-Techie mentioned this issue May 1, 2023
10 tasks
@confused-Techie
Copy link
Member

This report is now bundled into a single issue #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants