Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Icon "Cut in Half" on Taskbar #188

Closed
5 tasks done
confused-Techie opened this issue Dec 2, 2022 · 11 comments · Fixed by #318
Closed
5 tasks done

Windows Icon "Cut in Half" on Taskbar #188

confused-Techie opened this issue Dec 2, 2022 · 11 comments · Fixed by #318
Labels
bug Something isn't working

Comments

@confused-Techie
Copy link
Member

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Does your issue already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

When opening Pulsar on Windows the taskbar icon is "cut in half"
image

Which OS does this happen on?

🪟 Windows

OS details

22H2 OS Build: 19045.2251

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

  1. Install Pulsar
  2. Launch Pulsar
  3. View Taskbar

Additional Information:

This issue is present until pinning the Application Icon to the taskbar, then it becomes resolved.

Seems this issue is exactly as reported here.

I've looked through our ./scripts/electron-builder.js and can't find how we could reproduce those results.

The only thing that may work is changing the windows binaries to include the .png. Since really when looking through the Pulsar install folder I can't locate the .ico at all. But am easily able to locate the .png.

So it's possible that Windows is somehow falling back to that icon? So it may be worth a try, and will attempt if I get the chance. Otherwise someone more familiar with Electron Builder could try and take a look here

@langstonzac25
Copy link

Same problem, I would defiantly start using it if they fixed that but since I am so into aesthetics that is a game changer for me.

@confused-Techie
Copy link
Member Author

Same problem, I would defiantly start using it if they fixed that but since I am so into aesthetics that is a game changer for me.

Well if you'd like to start using Pulsar, if you pin the app to your taskbar this issue is resolved while pinned.

I'm looking into what we can do to fix it, but that is a workaround at this time.

@langstonzac25
Copy link

Ok it does have a full icon till I open it. Then it has a second icon in the taskbar with the half icon. Here is a picture for reference.
image

@confused-Techie
Copy link
Member Author

Ok it does have a full icon till I open it. Then it has a second icon in the taskbar with the half icon. Here is a picture for reference. image

Super interesting, I haven't seen that yet. Although I do group my taskbar icons so that might be it. Thanks for posting this to know it still does happen for that one window instance

@langstonzac25
Copy link

Actually that is just when I pin it from the start menu. When I open the app then pin it to the taskbar it keeps the icon when opened and closed. So I am content now now there is only the half icon in the title bar in windows but do not care about that as much. See picture.
image

@confused-Techie
Copy link
Member Author

@langstonzac25 Glad to here we've found a suitable workaround, but lets hope we can find a proper resolution soon

@RonnyAL
Copy link

RonnyAL commented Jan 6, 2023

Could the solutions suggested here work? I am not in a position to test this myself at the moment, but hopefully this could prove helpful to those who are able to test.

@confused-Techie
Copy link
Member Author

Could the solutions suggested here work? I am not in a position to test this myself at the moment, but hopefully this could prove helpful to those who are able to test.

Appreciate the ideas, but yeah that's the same link I've got at the bottom of the issue.

While they have the exact same issue, I've tried and failed to see how the solution is applicable. Since there's seemed to be from a lack of specificity in the icon, which isn't true for ourselves. Our electron-builder config points directly to the image, but there are some other possibilities listed which seem less likely but still possible

@DeeDeeG
Copy link
Member

DeeDeeG commented Jan 6, 2023

I had read somewhere that limiting the color bit-depth of the icon file to 8-bit color fixed it for someone?

Worth a try?

@langstonzac25
Copy link

I have solved my problem by installing the cirrus CI binaries. You do not need to uninstall your original insall. Just download the new installer run it and it will update your install. Then launch pulsar. It now displays the full icon in the taskbar. I hope this helps.

@Daeraxa
Copy link
Member

Daeraxa commented Jan 17, 2023

We made a new release a couple of days ago so this should work on the beta version too now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants