Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin doesn't handle or indicate an unsafe repository (where the directory owner is not me!) #28

Open
5 tasks done
AzzaAzza69 opened this issue May 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@AzzaAzza69
Copy link

AzzaAzza69 commented May 12, 2023

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Have you checked to make sure your issue does not already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

If opening a folder one deep from parent, it only offers the Create initial repository.
If opening the parent folder, it shows that it is git-tracked but does not display any commit history.

Once the git command "git config --global --add safe.directory {pathname}" has been done, everything works as expected.

Pulsar version

1.104.2023051203

Which OS does this happen on?

🪟 Windows

OS details

Windows 7

Which CPU architecture are you running this on?

64-bit(x86_64)

What steps are needed to reproduce this?

see "what happened"...

Additional Information:

see https://github.blog/2022-04-12-git-security-vulnerability-announced/ for more info...

@AzzaAzza69 AzzaAzza69 added the bug Something isn't working label May 12, 2023
@confused-Techie
Copy link
Member

Thanks for reporting this!

I do want to mention that often times Pulsar uses the version of Git that's already on your System. So please ensure that you're up to date there.

Otherwise for the few tasks that do still use some other version of Git, we will have to see about upgrading those.

@AzzaAzza69
Copy link
Author

It's a windows 7 vm that doesn't have have git already installed. In fact, it was after I installed another editor (that also used its own copy of git) that this one told me it was unsafe and prompted me to trust it the repo, after which I could open it in Pulsar...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants