diff --git a/README.md b/README.md index f515566..68e70c2 100644 --- a/README.md +++ b/README.md @@ -19,9 +19,9 @@ jobs: - name: Checkout the Latest Package Code uses: actions/checkout@v3 - name: Setup Pulsar Editor - uses: pulsar-edit/action-pulsar-dependency@v3 + uses: pulsar-edit/action-pulsar-dependency@v3.2 - name: Run the headless Pulsar Tests - uses: GabrielBB/xvfb-action@v1 + uses: coactions/setup-xvfb@v1.0.1 with: run: pulsar --test spec @@ -29,4 +29,6 @@ jobs: The above is a valid workflow for any package repository. -Otherwise using `GabrielBB/xvfb-action` is recommended because otherwise the tests will attempt to startup Electron from Pulsar and fail when they are unable to connect to a display. +Otherwise using `coactions/setup-xvfb` is recommended because otherwise the tests will attempt to startup Electron from Pulsar and fail when they are unable to connect to a display. + +Using `coactions/setup-xvfb` over `GabrielBB/xvfb-action` is recommended because it appears unmaintained anymore, and Nodejs 12 actions are deprecated diff --git a/action.yml b/action.yml index f060460..1277f1e 100644 --- a/action.yml +++ b/action.yml @@ -19,8 +19,9 @@ runs: curl -L "https://download.pulsar-edit.dev/?os=intel_mac&type=mac_dmg" --output pulsar.dmg hdiutil attach pulsar.dmg sudo cp -rf /Volumes/Pulsar*/Pulsar.app /Applications - xattr -cr /Applications/Pulsar.app/ - sudo ln -s /Applications/Pulsar.app/Contents/MacOS/Pulsar /usr/local/bin/pulsar + sudo mkdir -p /usr/local/bin/ + sudo ln -s /Applications/Pulsar.app/Contents/Resources/pulsar.sh /usr/local/bin/pulsar + #sudo ln -s /Applications/Pulsar.app/Contents/Resources/app/ppm/bin/apm /usr/local/bin/ppm - if: runner.os == 'Windows' shell: pwsh run: | @@ -32,8 +33,10 @@ runs: $wc.DownloadFile($url, $downloadPath) Write-Host "Installing Pulsar - this may take awhile" - Start-Process -FilePath $downloadPath + Start-Process -FilePath $downloadPath -ArgumentList '/currentuser', '/S' -Wait Write-Host "Pulsar Install completed" - $Env:PATH += ";$env:LOCALAPPDATA\Programs\Pulsar" - $env:Path = [System.Environment]::GetEnvironmentVariable("Path","Machine") + ";" + [System.Environment]::GetEnvironmentVariable("Path","User") + Write-Host "Adding Pulsar and PPM directories to GITHUB_PATH" + + "$env:LOCALAPPDATA\Programs\Pulsar\" >> $env:GITHUB_PATH + "$env:LOCALAPPDATA\Programs\Pulsar\resources\app\ppm\bin\" >> $env:GITHUB_PATH