Skip to content

Commit

Permalink
Merge pull request #650 from mdellweg/remove_prepip
Browse files Browse the repository at this point in the history
Remove prepip

(cherry picked from commit 26eefd4)
  • Loading branch information
mdellweg authored and patchback[bot] committed Sep 24, 2024
1 parent 71b4c98 commit dcba1de
Show file tree
Hide file tree
Showing 12 changed files with 26 additions and 26 deletions.
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ settings/
containers/
pgsql/
pulp_storage/
s6-overlay-amd64.tar.gz
17 changes: 1 addition & 16 deletions images/Containerfile.core.base
Original file line number Diff line number Diff line change
Expand Up @@ -73,22 +73,6 @@ RUN dnf -y install python${PYTHON_VERSION} python3-cryptography python${PYTHON_V
getcap /usr/bin/newuidmap | grep cap_setuid || dnf -y reinstall -y shadow-utils && \
dnf clean all

# Needed to prevent the wrong version of cryptography from being installed,
# which would break PyOpenSSL.
# Need to install optional dep, rhsm, for pulp-certguard
RUN pip3 install --upgrade pip setuptools wheel && \
rm -rf /root/.cache/pip && \
pip3 install \
rhsm \
setproctitle \
gunicorn \
python-nginx \
django-auth-ldap \
django-storages\[boto3,azure]\>=1.12.2 \
requests\[use_chardet_on_py3] && \
rm -rf /root/.cache/pip


RUN groupadd -g 700 --system pulp
RUN useradd -d /var/lib/pulp --system -u 700 -g pulp pulp

Expand Down Expand Up @@ -130,6 +114,7 @@ COPY images/assets/add_signing_service.sh /usr/bin/add_signing_service.sh
COPY images/assets/pulp-api /usr/bin/pulp-api
COPY images/assets/pulp-content /usr/bin/pulp-content
COPY images/assets/pulp-worker /usr/bin/pulp-worker
COPY images/assets/constraints.txt /constraints.txt

# Need to precreate when running pulp as the pulp user
RUN touch /var/log/galaxy_api_access.log && \
Expand Down
2 changes: 2 additions & 0 deletions images/assets/constraints.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
pulpcore>=3.21
pulp_container>=2.14
4 changes: 3 additions & 1 deletion images/galaxy-minimal/nightly/Containerfile.core
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
ARG FROM_TAG="latest"
FROM pulp/base:${FROM_TAG}

RUN pip3 install git+https://github.com/ansible/galaxy_ng
RUN pip3 install git+https://github.com/ansible/galaxy_ng \
-c /constraints.txt && \
rm -rf /root/.cache/pip

USER pulp:pulp
RUN PULP_STATIC_ROOT=/var/lib/operator/static/ PULP_CONTENT_ORIGIN=localhost \
Expand Down
3 changes: 2 additions & 1 deletion images/galaxy-minimal/stable/Containerfile.core
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ ARG GALAXY_NG_VERSION=""

RUN pip3 install --upgrade \
galaxy-ng${GALAXY_NG_VERSION} \
pulpcore${PULPCORE_VERSION} && \
pulpcore${PULPCORE_VERSION} \
-c /constraints.txt && \
rm -rf /root/.cache/pip

# Prevent pip-installed /usr/local/bin/pulp-content from getting run instead of
Expand Down
3 changes: 2 additions & 1 deletion images/galaxy/nightly/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@ ARG GALAXY_NG_VERSION=""

RUN pip3 install --upgrade \
git+https://github.com/ansible/galaxy_ng.git@master \
requests && \
requests \
-c /constraints.txt && \
rm -rf /root/.cache/pip

USER pulp:pulp
Expand Down
3 changes: 2 additions & 1 deletion images/galaxy/stable/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ ARG GALAXY_NG_VERSION=""
RUN pip3 install --upgrade \
galaxy-ng${GALAXY_NG_VERSION} \
pulpcore${PULPCORE_VERSION} \
requests && \
requests \
-c /constraints.txt && \
rm -rf /root/.cache/pip

USER pulp:pulp
Expand Down
6 changes: 4 additions & 2 deletions images/pulp-minimal/nightly/Containerfile.core
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,12 @@ RUN pip3 install git+https://github.com/pulp/pulpcore.git#egg=pulpcore \
git+https://github.com/pulp/pulp_file.git \
git+https://github.com/pulp/pulp_gem.git \
git+https://github.com/pulp/pulp_maven.git \
git+https://github.com/pulp/pulp_npm.git \
git+https://github.com/pulp/pulp_ostree.git \
git+https://github.com/pulp/pulp_python.git \
git+https://github.com/pulp/pulp_rpm.git
git+https://github.com/pulp/pulp_rpm.git \
rhsm \
-c /constraints.txt && \
rm -rf /root/.cache/pip

USER pulp:pulp
RUN PULP_STATIC_ROOT=/var/lib/operator/static/ PULP_CONTENT_ORIGIN=localhost \
Expand Down
4 changes: 3 additions & 1 deletion images/pulp-minimal/stable/Containerfile.core
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ RUN pip3 install --upgrade \
pulp-maven${PULP_MAVEN_VERSION} \
pulp-python${PULP_PYTHON_VERSION} \
pulp-rpm${PULP_RPM_VERSION} \
pulp-ostree${PULP_OSTREE_VERSION} && \
pulp-ostree${PULP_OSTREE_VERSION} \
rhsm \
-c /constraints.txt && \
rm -rf /root/.cache/pip

# Prevent pip-installed /usr/local/bin/pulp-content from getting run instead of
Expand Down
4 changes: 2 additions & 2 deletions images/pulp/nightly/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ RUN pip3 install --upgrade \
git+https://github.com/pulp/pulp_file@main \
git+https://github.com/pulp/pulp_gem@main \
git+https://github.com/pulp/pulp_maven@main \
git+https://github.com/pulp/pulp_npm@main \
git+https://github.com/pulp/pulp_ostree@main \
git+https://github.com/pulp/pulp_python@main \
git+https://github.com/pulp/pulp_rpm@main \
requests && \
rhsm \
-c /constraints.txt && \
rm -rf /root/.cache/pip

USER pulp:pulp
Expand Down
4 changes: 3 additions & 1 deletion images/pulp/stable/Containerfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,9 @@ RUN pip3 install --upgrade \
pulp-python${PULP_PYTHON_VERSION} \
pulp-rpm${PULP_RPM_VERSION} \
pulp-ostree${PULP_OSTREE_VERSION} \
requests && \
rhsm \
requests \
-c /constraints.txt && \
rm -rf /root/.cache/pip

USER pulp:pulp
Expand Down
1 change: 1 addition & 0 deletions images/s6_assets/openssl.cnf
Original file line number Diff line number Diff line change
Expand Up @@ -375,3 +375,4 @@ DNS.3 = ci.pulp.com
DNS.4 = galaxy
DNS.5 = galaxy.example.com
DNS.6 = ci.galaxy.com
DNS.7 = pulp-ephemeral

0 comments on commit dcba1de

Please sign in to comment.