Adding option to disable Tika #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If we do this we should fork the UCSD lib and do it there - external_roles should just be vendored git repos, is my understanding. |
|
Oh, that makes sense — is there a standard way to update the FITS module, assuming they merge our PR? |
|
@escowles If there is I don't know it - if they distribute it to galaxy I assume we just run the command to pull it down again? |
|
I've submitted a PR to UCSD's repo: ucsdlib/ansible-role-fits#2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable Tika to dramatically reduce the FITS execution time (from 90+ seconds to 20 seconds).