From 7cdd358f151668c8d2179c40a3e8bdc187202771 Mon Sep 17 00:00:00 2001
From: Hector Correa <hector_correa@princeton.edu>
Date: Fri, 16 Aug 2024 16:43:49 +0200
Subject: [PATCH] Changed the link for the how to submit and deleted unused
 code

---
 app/controllers/home_controller.rb   |  2 --
 app/views/home/submit.html.erb       | 48 ----------------------------
 app/views/shared/_nav_links.html.erb |  2 +-
 config/routes.rb                     |  1 -
 spec/requests/static_spec.rb         |  5 ---
 spec/system/front_page_spec.rb       |  2 +-
 6 files changed, 2 insertions(+), 58 deletions(-)
 delete mode 100644 app/views/home/submit.html.erb

diff --git a/app/controllers/home_controller.rb b/app/controllers/home_controller.rb
index 42654ed4..3dfd3c3f 100644
--- a/app/controllers/home_controller.rb
+++ b/app/controllers/home_controller.rb
@@ -5,8 +5,6 @@ def about; end
 
   def features; end
 
-  def submit; end
-
   def policies; end
 
   def contributors; end
diff --git a/app/views/home/submit.html.erb b/app/views/home/submit.html.erb
deleted file mode 100644
index c14a0cf2..00000000
--- a/app/views/home/submit.html.erb
+++ /dev/null
@@ -1,48 +0,0 @@
-<style>
-  .first-section {
-    padding-top: 6px;
-  }
-</style>
-
-<h2>How to Submit to Princeton's Research Data Repository</h2>
-
-<h3 class="first-section">Who can submit to this repository?</h3>
-<p>All faculty, staff and students of Princeton University are welcome to submit their 
-digital research data and code to Princeton's PDC Research Data Repository.</p>
-
-<h3>Steps to get started</h3>
-<p>
-See <%= link_to "Getting Started as a Princeton Data Commons Contributor", "https://researchdata.princeton.edu/research-lifecycle-guide/getting-started-princeton-data-commons-describe-contributor", target: "_blank" %> for more detailed instructions.
-</p>
-<ol>
-  <li>
-  Prepare your files: Ensure data is suitable for public release, in accessible formats, adequately documented, and compressed as needed.
-  </li>
-
-  <li>
-  Review the PDC policies for <%= link_to "Acceptance and Retention", "https://drive.google.com/file/d/1GECvKoOjwqvKTKYvyNThCyzTWjD6cPxs/view", target: "_blank" %> and <%= link_to "Distribution", "https://drive.google.com/file/d/1E8EgfyL2yB2rH0xCIIqYrTFE0QfY8Sk_/view", target: "_blank" %>: Be sure your intended submission is 
-  eligible for PDC, that you are authorized to grant permission for redistribution, and that you are prepared to pay any applicable costs. 
-  If you are unsure about any of these points, please <%= link_to "contact PRDS", "mailto:prds@princeton.edu" %> before submitting.
-  </li>
-
-  <li>
-  Log in to <%= link_to "PDC Describe", "https://datacommons.princeton.edu/describe/", target: "_blank" %>: Log in using your NetID and set up your Profile.
-  </li>
-
-  <li>
-  Create a new item and fill out Metadata fields: start a new submission from your dashboard, this will create a draft DOI for the new submission. Fill out the “Required” and “Additional” Metadata fields in the webform.
-  </li>
-
-  <li>
-  Upload a Readme file and data files: Upload a README file to reiterate and supplement the metadata completed in the online form. 
-  Upload data/code files that are under 100MB directly to the webform. If larger than 100MB, describe where your files are located and how to retrieve them, in the field provided (see our <%= link_to "considerations for large datasets", "https://researchdata.princeton.edu/research-lifecycle-guide/publishing-large-datasets", target: "_blank" %>).
-  </li>
-
-  <li>
-  Submit for curatorial review: You must complete your submission through the web portal in order for the curation of your dataset to begin. The review process typically takes 5-10 business days.
-  </li>
-
-  <li>
-  Receive notice of publication: The PDC Describe system will notify you when your item has been accepted, and the curators will follow up with a confirmation email including relevant details and links.
-  </li>
-</ol>
\ No newline at end of file
diff --git a/app/views/shared/_nav_links.html.erb b/app/views/shared/_nav_links.html.erb
index f4a392fd..00d0104b 100644
--- a/app/views/shared/_nav_links.html.erb
+++ b/app/views/shared/_nav_links.html.erb
@@ -2,5 +2,5 @@
   <li class="nav-item"><a class="nav-link" href="<%= root_path %>">Home</a></li>
   <li class="nav-item"><a class="nav-link" href="<%= home_about_path %>">About</a></li>
   <li class="nav-item"><a class="nav-link" href="<%= home_features_path %>">Features</a></li>
-  <li class="nav-item"><a class="nav-link" href="<%= home_submit_path %>">How to Submit</a></li>
+  <li class="nav-item"><a class="nav-link" href="https://datacommons.princeton.edu/describe/" target="_blank">How to Submit</a></li>
 </ul>
diff --git a/config/routes.rb b/config/routes.rb
index 224271c9..4c63b1d2 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -38,7 +38,6 @@
 
   get 'about' => 'home#about', as: :home_about
   get 'features' => 'home#features', as: :home_features
-  get 'submit' => 'home#submit', as: :home_submit
   get 'policies' => 'home#policies', as: :home_policies
   get 'contributors' => 'home#contributors', as: :home_contributors
 
diff --git a/spec/requests/static_spec.rb b/spec/requests/static_spec.rb
index e346b7e4..3ba11b02 100644
--- a/spec/requests/static_spec.rb
+++ b/spec/requests/static_spec.rb
@@ -6,9 +6,4 @@
     get "/about"
     expect(response).to have_http_status(:success)
   end
-
-  it "has a how to submit page" do
-    get "/submit"
-    expect(response).to have_http_status(:success)
-  end
 end
diff --git a/spec/system/front_page_spec.rb b/spec/system/front_page_spec.rb
index bc42f570..94b1a031 100644
--- a/spec/system/front_page_spec.rb
+++ b/spec/system/front_page_spec.rb
@@ -27,7 +27,7 @@
       visit '/'
       expect(page).to have_link "Home", href: "/"
       expect(page).to have_link "About", href: "/about"
-      expect(page).to have_link "How to Submit", href: "/submit"
+      expect(page).to have_link "How to Submit", href: "https://datacommons.princeton.edu/describe/"
       expect(page).to have_link "Accessibility", href: "https://accessibility.princeton.edu/help"
     end
   end